-
-
Notifications
You must be signed in to change notification settings - Fork 3k
fix(merge-dialog): fix 'treat duplicates the same way' checkbox #14224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
InAnYan
wants to merge
6
commits into
JabRef:main
Choose a base branch
from
InAnYan:fix/treat-duplicates-same
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+21
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
reviewed
Nov 2, 2025
Siedlerchr
reviewed
Nov 2, 2025
jabgui/src/main/java/org/jabref/gui/duplicationFinder/DuplicateSearch.java
Outdated
Show resolved
Hide resolved
subhramit
reviewed
Nov 3, 2025
subhramit
reviewed
Nov 3, 2025
jabgui/src/main/java/org/jabref/gui/duplicationFinder/DuplicateSearch.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Subhramit Basu <[email protected]>
InAnYan
commented
Nov 6, 2025
subhramit
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/JabRef/jabref-issue-melting-pot/issues/720
Previously, if your library had a lot of duplicate entries, and you want to quickly merge them, you couldn't do this easily. There is a checkbox "Treat duplicates the same way", but it never worked. This PR solves this program, and it works now like this:
Scenario 1:
Scenario 2:
Scenario 3 (checkbox was ticked previously):
I put Scenario 3 here, because even if the checkbox is ticked, there is a way to untick it.
Steps to test
After that JabRef merges duplicates automatically.
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)